- 30 Mar, 2022 1 commit
-
-
Sergey Latyshkov authored
-
- 16 Apr, 2021 4 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
* 5.2: [Console] : added phpdocs to InputOption constants
-
Fabien Potencier authored
* 4.4: [Console] : added phpdocs to InputOption constants
-
Markus Staab authored
-
- 09 Apr, 2021 2 commits
-
-
Fabien Potencier authored
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Console] Deprecate Helper::strlen() for width() and length() | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | yes | Deprecations? | yes | Tickets | Follow up form #40698 | License | MIT | Doc PR | This PR will deprecated `Helper::strlen()` since it is actually calculating the width. I remove the `@internal` on `Helper::width()` and a `Helper::length()`. I will also deprecate `Helper::strlenWithoutDecoration()` because you should use `Helper::removeDecoration()` instead. Commits ------- 3c24aa9d47 [Console] Deprecate Helper::strlen() for width() and length()
-
Nyholm authored
-
- 08 Apr, 2021 7 commits
-
-
Robin Chalas authored
* 5.2: [PHPDoc] Fix some union type cases
-
Robin Chalas authored
* 4.4: [PHPDoc] Fix some union type cases
-
Nyholm authored
This PR was merged into the 4.4 branch. Discussion ---------- [PHPDoc] Fix some union type cases | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - While working on https://github.com/symfony/symfony/issues/40154, I discovered some PHPDoc issues, I'm going to comment in the review. Upper branches will need some fixes too. Commits ------- dd1481642b [PHPDoc] Fix some union type cases
-
Fabien Potencier authored
* 5.2: Add test. [Console] Add Helper::strwidth() and Helper::strlength() Update README.md
-
Fabien Potencier authored
This PR was merged into the 5.2 branch. Discussion ---------- [Console] Add Helper::width() and Helper::length() | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Close #40697 Fix #40634, fix #40635 | License | MIT | Doc PR | This PR will add add a Helper::strwidth() and a Helper::strlength(). Same with with the Helper::strlenWithoutDecoration(). It does not deprecate anything. That is done in #40695 With this PR we dont have to revert the emoji issue (ie close #40697) FYI @grasmash, I used your tests from #40635 Commits ------- d9ea4c597c Add test. dc02ab3d74 [Console] Add Helper::strwidth() and Helper::strlength()
-
Matthew Grasmick authored
-
Nyholm authored
-
- 07 Apr, 2021 4 commits
-
-
Thomas Calvet authored
-
Alexander M. Turek authored
* 5.2: [CS] Replace easy occurences of ?: with ??
-
Alexander M. Turek authored
* 4.4: [CS] Replace easy occurences of ?: with ??
-
Thomas Calvet authored
-
- 28 Mar, 2021 2 commits
-
-
Christian Flothmann authored
* 5.2: skip intl dependent tests if the extension is missing make DateCaster tests timezone-agnostic error if the input string couldn't be parsed as a date IntegerType: Always use en for IntegerToLocalizedStringTransformer Fixes #40456 Uses the correct assignment action for console options depending if they are short or long [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams FIx Trying to clone an uncloneable object of class
-
Christian Flothmann authored
* 4.4: skip intl dependent tests if the extension is missing make DateCaster tests timezone-agnostic error if the input string couldn't be parsed as a date IntegerType: Always use en for IntegerToLocalizedStringTransformer Fixes #40456 Uses the correct assignment action for console options depending if they are short or long [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams FIx Trying to clone an uncloneable object of class
-
- 26 Mar, 2021 1 commit
-
-
Roberto Nygaard authored
-
- 23 Mar, 2021 4 commits
-
-
Nicolas Grekas authored
-
Robin Chalas authored
* 5.2: [Console] minor fix [Command] fix emojis messing up the line width [Validator] Avoid triggering the autoloader for user-input values Hardening Security - Unserialize DumpDataCollector Security hardening - Rate limiter [FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized Fixed parsing deprecated definitions without message key improve login throttling rate limiter requirement message [HttpClient] remove using $http_response_header [Security] Handle properly 'auto' option for remember me cookie security
-
Nicolas Grekas authored
-
Marion Hurteau authored
add tests + removed irrelevant method
-
- 17 Mar, 2021 5 commits
-
-
Nicolas Grekas authored
* 5.2: [Console] Fix line wrapping for decorated text in block output [Inflector] Fixed pluralize "coupon" [PhpUnitBridge] fix compat with symfony/debug [VarDumper] Adds support for ReflectionUnionType to VarDumper Correctly clear lines for multi-line progress bar messages. [Security] Add XML support for authenticator manager
-
Nicolas Grekas authored
* 4.4: [Console] Fix line wrapping for decorated text in block output [Inflector] Fixed pluralize "coupon" [PhpUnitBridge] fix compat with symfony/debug [VarDumper] Adds support for ReflectionUnionType to VarDumper Correctly clear lines for multi-line progress bar messages.
-
Nicolas Grekas authored
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Console] Fix line wrapping for decorated text in block output | Q | A | ------------- | --- | Branch? | | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Fixed bug that caused decorated text to be wrapped too early in SymfonyStyle->block(). Commits ------- 760be88310 [Console] Fix line wrapping for decorated text in block output
-
Matthew Grasmick authored
-
Matthew Grasmick authored
-
- 16 Mar, 2021 4 commits
-
-
Nicolas Grekas authored
This PR was merged into the 5.3-dev branch. Discussion ---------- Deprecate configuring tag names and service ids in compiler passes | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - This PR is aimed at reducing the code complexity by hardcoding the name of tags and service ids that compiler passes have to deal with. I think making these names configurable only adds boilerplate and maintenance overhead for no benefit: - for the practice: the need to use a pass with a renamed tag/id should be extremely rare (do yo know any?) - for the theory: a decorating pass could still rename before/after the processing, so this use case is still supported. Side note: I skipped updating changelog+upgrade files. This would be just noise to me (nobody uses this possibility anyway ;) ) Commits ------- 6fe82d8be7 Deprecate configuring tag names and service ids in compiler passes
-
Nicolas Grekas authored
* 5.2: [ErrorHandler] Fix error caused by `include` + open_basedir [FrameworkBundle] Make the TestBrowserToken interchangeable with other tokens [Console] ProgressBar clears too many lines on update [FrameworkBundle] Exclude unreadable files when executing About command [Bridge\Twig] Add 'form-control-range' for range input type Be explicit about transparent background color of links in toolbar [Translation] fix test case name [Cache] Fix wrong namespace in test [DependencyInjection] Fix return type
-
Nicolas Grekas authored
* 4.4: [Console] ProgressBar clears too many lines on update [FrameworkBundle] Exclude unreadable files when executing About command [Bridge\Twig] Add 'form-control-range' for range input type Be explicit about transparent background color of links in toolbar [Translation] fix test case name [Cache] Fix wrong namespace in test [DependencyInjection] Fix return type
-
Dane Powell authored
-
- 15 Mar, 2021 1 commit
-
-
Nicolas Grekas authored
-
- 12 Mar, 2021 3 commits
-
-
Fabien Potencier authored
minor #40322 [Console] improve exception message when required argument is added after an optional one (marbul) This PR was merged into the 5.3-dev branch. Discussion ---------- [Console] improve exception message when required argument is added after an optional one | Q | A | ------------- | --- | Branch? | 5.x <!-- see below --> | Bug fix? | no | New feature? | wouldn't say so, rather DX improvement <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #40302 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | n/a Hello, this is my first contribution to Symfony Framework. It's time to pull my weight. About the issue: I did improve an error message to include passed argument's name and the latest optional argument's name.  An author also mentioned "But which command?", however this is shown twice as we can see on the screenshot above so I skipped that. Commits ------- 9bddbbd7ed #40302 improve exception message when required argument is added after an optional one
-
Alexander M. Turek authored
* 5.2: bug #40427 [Console] Stop accepting ints as InputOption defaults Fix fingerprint when context is not serializable Fix `ConstraintViolation#getMessageTemplate()` to always return `string`
-
Alexander M. Turek authored
* 4.4: bug #40427 [Console] Stop accepting ints as InputOption defaults Fix fingerprint when context is not serializable
-
- 11 Mar, 2021 1 commit
-
-
Oliver Klee authored
The types accepted and provided by `InputInterface::getOption` and `setOption` do not include `int` (and passing something like `--option=123` will set the option to the string `"123"`, not to the integer `123`). The `InputOption` default types should match this.
-
- 08 Mar, 2021 1 commit
-
-
Benjamin Franzke authored
Motivations for this change: * Avoid an unneded preg call, explode+implode is faster * The previous regex created to suboptimal expressions, due to the pipe that caused empty to be matched. That means an input like `foo:bar` was translated into `foo[^:]*[^:]*:bar[^:]*[^:]*` instead of simply `foo[^:]*:bar[^:]*`
-