1. 30 Mar, 2022 1 commit
  2. 16 Apr, 2021 4 commits
  3. 09 Apr, 2021 2 commits
    • Fabien Potencier's avatar
      feature #40695 [Console] Deprecate Helper::strlen() for width() and length() (Nyholm) · 9a90698d
      Fabien Potencier authored
      This PR was squashed before being merged into the 5.3-dev branch.
      
      Discussion
      ----------
      
      [Console] Deprecate Helper::strlen() for width() and length()
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.2
      | Bug fix?      | yes
      | New feature?  | yes
      | Deprecations? | yes
      | Tickets       | Follow up form #40698
      | License       | MIT
      | Doc PR        |
      
      This PR will deprecated `Helper::strlen()` since it is actually calculating the width. I remove the `@internal` on `Helper::width()` and a `Helper::length()`. I will also deprecate `Helper::strlenWithoutDecoration()` because you should use `Helper::removeDecoration()` instead.
      
      Commits
      -------
      
      3c24aa9d47 [Console] Deprecate Helper::strlen() for width() and length()
      9a90698d
    • Nyholm's avatar
      1eda6bb5
  4. 08 Apr, 2021 7 commits
  5. 07 Apr, 2021 4 commits
  6. 28 Mar, 2021 2 commits
    • Christian Flothmann's avatar
      Merge branch '5.2' into 5.x · fb7e2447
      Christian Flothmann authored
      * 5.2:
        skip intl dependent tests if the extension is missing
        make DateCaster tests timezone-agnostic
        error if the input string couldn't be parsed as a date
        IntegerType: Always use en for IntegerToLocalizedStringTransformer Fixes #40456
        Uses the correct assignment action for console options depending if they are short or long
        [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel
        [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams
        FIx Trying to clone an uncloneable object of class
      fb7e2447
    • Christian Flothmann's avatar
      Merge branch '4.4' into 5.2 · 35f039df
      Christian Flothmann authored
      * 4.4:
        skip intl dependent tests if the extension is missing
        make DateCaster tests timezone-agnostic
        error if the input string couldn't be parsed as a date
        IntegerType: Always use en for IntegerToLocalizedStringTransformer Fixes #40456
        Uses the correct assignment action for console options depending if they are short or long
        [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel
        [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams
        FIx Trying to clone an uncloneable object of class
      35f039df
  7. 26 Mar, 2021 1 commit
  8. 23 Mar, 2021 4 commits
    • Nicolas Grekas's avatar
      Add `#[As-prefix]` to service attributes · 6cc8bd44
      Nicolas Grekas authored
      6cc8bd44
    • Robin Chalas's avatar
      Merge branch '5.2' into 5.x · 5da8b675
      Robin Chalas authored
      * 5.2:
        [Console] minor fix
        [Command] fix emojis messing up the line width
        [Validator] Avoid triggering the autoloader for user-input values
        Hardening Security - Unserialize DumpDataCollector
        Security hardening - Rate limiter
        [FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized
        Fixed parsing deprecated definitions without message key
        improve login throttling rate limiter requirement message
        [HttpClient] remove using $http_response_header
        [Security] Handle properly 'auto' option for remember me cookie security
      5da8b675
    • Nicolas Grekas's avatar
      [Console] minor fix · 075ea649
      Nicolas Grekas authored
      075ea649
    • Marion Hurteau's avatar
      [Command] fix emojis messing up the line width · 054f5487
      Marion Hurteau authored
      add tests + removed irrelevant method
      054f5487
  9. 17 Mar, 2021 5 commits
  10. 16 Mar, 2021 4 commits
    • Nicolas Grekas's avatar
      feature #40468 Deprecate configuring tag names and service ids in compiler passes (nicolas-grekas) · 72999246
      Nicolas Grekas authored
      This PR was merged into the 5.3-dev branch.
      
      Discussion
      ----------
      
      Deprecate configuring tag names and service ids in compiler passes
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.x
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | yes
      | Tickets       | -
      | License       | MIT
      | Doc PR        | -
      
      This PR is aimed at reducing the code complexity by hardcoding the name of tags and service ids that compiler passes have to deal with.
      
      I think making these names configurable only adds boilerplate and maintenance overhead for no benefit:
      - for the practice: the need to use a pass with a renamed tag/id should be extremely rare (do yo know any?)
      - for the theory: a decorating pass could still rename before/after the processing, so this use case is still supported.
      
      Side note: I skipped updating changelog+upgrade files. This would be just noise to me (nobody uses this possibility anyway ;) )
      
      Commits
      -------
      
      6fe82d8be7 Deprecate configuring tag names and service ids in compiler passes
      72999246
    • Nicolas Grekas's avatar
      Merge branch '5.2' into 5.x · 54e1fc93
      Nicolas Grekas authored
      * 5.2:
        [ErrorHandler] Fix error caused by `include` + open_basedir
        [FrameworkBundle] Make the TestBrowserToken interchangeable with other tokens
        [Console] ProgressBar clears too many lines on update
        [FrameworkBundle] Exclude unreadable files when executing About command
        [Bridge\Twig] Add 'form-control-range' for range input type
        Be explicit about transparent background color of links in toolbar
        [Translation] fix test case name
        [Cache] Fix wrong namespace in test
        [DependencyInjection] Fix return type
      54e1fc93
    • Nicolas Grekas's avatar
      Merge branch '4.4' into 5.2 · a3528eb1
      Nicolas Grekas authored
      * 4.4:
        [Console] ProgressBar clears too many lines on update
        [FrameworkBundle] Exclude unreadable files when executing About command
        [Bridge\Twig] Add 'form-control-range' for range input type
        Be explicit about transparent background color of links in toolbar
        [Translation] fix test case name
        [Cache] Fix wrong namespace in test
        [DependencyInjection] Fix return type
      a3528eb1
    • Dane Powell's avatar
      eaa700fb
  11. 15 Mar, 2021 1 commit
  12. 12 Mar, 2021 3 commits
    • Fabien Potencier's avatar
      minor #40322 [Console] improve exception message when required argument is... · e8bee16c
      Fabien Potencier authored
      minor #40322 [Console] improve exception message when required argument is added after an optional one (marbul)
      
      This PR was merged into the 5.3-dev branch.
      
      Discussion
      ----------
      
      [Console] improve exception message when required argument is added after an optional one
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.x <!-- see below -->
      | Bug fix?      | no
      | New feature?  | wouldn't say so, rather DX improvement <!-- please update src/**/CHANGELOG.md files -->
      | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
      | Tickets       | Fix #40302 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
      | License       | MIT
      | Doc PR        | n/a
      
      Hello, this is my first contribution to Symfony Framework. It's time to pull my weight.
      About the issue:
      I did improve an error message to include passed argument's name and the latest optional argument's name.
      ![Screenshot at 2021-02-26 23-08-10](https://user-images.githubusercontent.com/79662742/109361609-8f011e80-7889-11eb-8700-cbbd388c0109.png)
      An author also mentioned "But which command?", however this is shown twice as we can see on the screenshot above so I skipped that.
      
      Commits
      -------
      
      9bddbbd7ed #40302 improve exception message when required argument is added after an optional one
      e8bee16c
    • Alexander M. Turek's avatar
      Merge branch '5.2' into 5.x · 1501706f
      Alexander M. Turek authored
      * 5.2:
        bug #40427 [Console] Stop accepting ints as InputOption defaults
        Fix fingerprint when context is not serializable
        Fix `ConstraintViolation#getMessageTemplate()` to always return `string`
      1501706f
    • Alexander M. Turek's avatar
      Merge branch '4.4' into 5.2 · 0aae1902
      Alexander M. Turek authored
      * 4.4:
        bug #40427 [Console] Stop accepting ints as InputOption defaults
        Fix fingerprint when context is not serializable
      0aae1902
  13. 11 Mar, 2021 1 commit
    • Oliver Klee's avatar
      bug #40427 [Console] Stop accepting ints as InputOption defaults · 3c65c2dd
      Oliver Klee authored
      The types accepted and provided by `InputInterface::getOption`
      and `setOption` do not include `int` (and passing something like
      `--option=123` will set the option to the string `"123"`, not
      to the integer `123`).
      
      The `InputOption` default types should match this.
      3c65c2dd
  14. 08 Mar, 2021 1 commit
    • Benjamin Franzke's avatar
      Avoid unneeded preg_replace_callback in console application · 4e102e4d
      Benjamin Franzke authored
      Motivations for this change:
       * Avoid an unneded preg call, explode+implode is faster
       * The previous regex created to suboptimal expressions,
         due to the pipe that caused empty to be matched.
      
         That means an input like `foo:bar`
         was translated into `foo[^:]*[^:]*:bar[^:]*[^:]*`
         instead of simply `foo[^:]*:bar[^:]*`
      4e102e4d